Skip to content

CLI shell completion omits servers/add, servers/edit, servers/remove and --output-format values #2629

Description

@cliffhall

Problem

Found by the 2.10.0 release smoke (#2623). --completion (#2434) completes --method from the one-shot methods plus a hard-coded CATALOG_METHODS = ["servers/list", "servers/show"] (clients/cli/src/completion.ts:43), so the catalog writes added in the same milestone (#2433: servers/add, servers/edit, servers/remove) are never offered. --output-format (#2431) also gets no value completion — it offers nothing rather than json raw.

Reproduce

source <(node clients/launcher/build/index.js --cli --completion bash)
# complete: mcp-inspector --cli --method serv<TAB>   → servers/list servers/show only
# complete: mcp-inspector --cli --output-format <TAB> → nothing

Expected

--method serv<TAB> offers all five servers/* methods; --output-format <TAB> offers json raw; in bash, zsh and fish. Ideally the method list derives from the same source the CLI dispatches on, so it cannot drift again.

Priority

Medium (rubric total 8): Severity 2 (completion gap, typing works), Urgency 4 (blocks the release merge — fixed before 2.10.0 ships), +1 bug, +1 milestoned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

bugSomething isn't workingv2Issues and PRs for v2

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions