Skip to content

Compare and decide which 'Inspector Core' approaches we want to incorporate into V1 and/or V2 #1030

Description

@olaservo

Context

Two parallel approaches to shared Inspector code:

PR #1023 (inspector-core) PR #1027 (InspectorClient)
Pattern Functions + Repository interfaces Class facade with EventTarget
Focus Type contracts + handler setup Full client lifecycle + state
State Stateless (consumer manages) Stateful (tracks messages, data)
React None Hook in separate module

Options

  1. Merge both - Merge approaches into combined core implementation
  2. Pick one - Can still adopt pieces from the other as needed
  3. Keep separate - Different use cases (V1 CLI/TUI) vs V2 web and potentially other use cases)

Decision Needed

Which pattern should be the foundation for V2's shared code layer?

Activity

  1. olaservo commented on Jan 21, 2026

    @olaservo
    MemberAuthor

    Clarifying - this isn't' blocking anything, more to understand what could be a more useful pattern than what we're already implementing with more of a web focus.

  2. cliffhall commented on Mar 7, 2026

    @cliffhall
    Member

    @olaservo @BobDickinson I vote we go with the InspectorClient, primarily because it already works and drives three clients, but also because it handles all the heavy-lifting, allowing the clients to be a lot simpler. We can always incorporate ideas from this approach as they make sense. We have some housekeeping to do I think, and part of it might be conceptual reorganizing.

  3. self-assigned this
    on May 27, 2026
  4. added this to the v2.0.0 milestone on Jul 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

v2Issues and PRs for v2

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions