Skip to content

Commit c489854

Browse files
authored
Merge pull request #2066 from modelcontextprotocol/v1/chore/2065-workflow-branch-triggers
ci(v1): pin workflow branch filters to v1/main, re-enabling the e2e gate
2 parents 47f9284 + 95fa9a1 commit c489854

2 files changed

Lines changed: 16 additions & 3 deletions

File tree

‎.github/workflows/e2e_tests.yml‎

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,14 @@
11
name: Playwright Tests
22

3+
# Pinned to `v1/main`, this branch's own base. These filters read `main`
4+
# historically, from when the v1 line was itself `main` — which meant they
5+
# matched nothing here and the suite silently never ran on this branch.
6+
# See #2065.
37
on:
48
push:
5-
branches: [main]
9+
branches: [v1/main]
610
pull_request:
7-
branches: [main]
11+
branches: [v1/main]
812

913
jobs:
1014
test:

‎.github/workflows/main.yml‎

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,18 @@
1+
# `v1/main` is the deprecated maintenance line: it publishes straight from this
2+
# branch to the `v1-latest` dist-tag and never merges into `main`, which now
3+
# carries v2. Keep these filters pinned to `v1/main` — a stale `main` entry here
4+
# describes a topology that no longer exists, and would start matching the moment
5+
# anything put a v1-shaped tree back on that branch.
6+
#
7+
# (For `push`, GitHub runs the workflow file from the pushed commit, so this file
8+
# is only ever consulted for `v1/main` regardless. The filter states intent.)
19
on:
210
push:
311
branches:
4-
- main
512
- v1/main
613
pull_request:
14+
branches:
15+
- v1/main
716
release:
817
types: [published]
918

0 commit comments

Comments
 (0)