mcp: improve http transports error handling and make buffer size configurable #734
+171
−31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findleyr
reviewed
Dec 23, 2025
| // http.DefaultClient is used. | ||
| HTTPClient *http.Client | ||
|
|
||
| // MaxLineSize is the maximum buffer size used when reading a message. It defaults to 1MB |
Contributor
There was a problem hiding this comment.
"MaxLineSize is the maximum buffer size (in bytes) used when reading SSE events. If unset, defaults to 1MiB."
Here, and in the streamable client.
| const maxTokenSize = 1 * 1024 * 1024 // 1 MiB max line size | ||
| scanner.Buffer(nil, maxTokenSize) | ||
| if maxLineSize == 0 { | ||
| maxLineSize = 1 * 1024 * 1024 // defaults to 1MB |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a use case for messages larger than 1MB, hence making this configurable would help.
In order to discover the source of our problems we had to spend some time investigating, as errors were silently discarded. So we also included changes to improving surfacing errors .