-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Track metrics for core
and std
crates, add loop metrics
#258
Conversation
The crate that we compute metrics for is now configurable when invoking `kani_std_analysis.py`. Should we find a need for further crates beyond `core` or `std` we just need to invoke it more times.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this!
core
and std
cratescore
and std
cratess, add loop metrics
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
We might want #261 to be merged first and we need model-checking/kani#3915 to be merged. |
core
and std
cratess, add loop metricscore
and std
crates, add loop metrics
This is now working as expected, see tautschnig#11. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you revert the changes to the submodules before we merge this?
Also, have you tested the plotting functionality to make sure that it renders okay even though the earlier dates don't have these datapoints?
This reverts commit 9c5e56a.
Thank you for catching this! (This is now fixed.)
With the data from tautschnig#11 we get the following for the And for the I believe these match expectations. |
The purple entry in the legend on the first graph looks off? But otherwise LGTM |
9aa99c3
The crate that we compute metrics for is now configurable when invoking
kani_std_analysis.py
. Should we find a need for further crates beyondcore
orstd
we just need to invoke it more times.We are now also reporting loop/no-loop information across all the kinds of functions we are tracking as metrics.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.