Add loop contracts and harness for run_utf8_validation
#159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
celinval
approved these changes
Nov 8, 2024
celinval
reviewed
Nov 8, 2024
zhassan-aws
reviewed
Nov 8, 2024
feliperodri
approved these changes
Nov 8, 2024
There was a problem hiding this comment.
This is awesome. A bit more documentation on the bounds that still exist in the harness would be more helpful, but I couldn't find any problem with the loop invariants that you added, thus, not blocking the PR. Can't wait to see some performance results in Kani using these contracts while verifying code that use strings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.