2.0 naming changes #351
Merged
2.0 naming changes #351
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an optional field so we need to check if it exists
- Remove checks for old style of ingredients - Generally we want to hide things rather than remove this. This is much better for mod compatibility and less likely to crash the game
- These recipe etc have been removed from Angel's - Remove references to normal / expensive - Use pairs, not ipairs
These changes should all have been implemented in Angel's. Unit tests will now check for missing prerequisites all the time, not just when Sea Block is enabled
- No need to set `localised_name`. Just having the same name in the .cfg file means that it will override
- Removed commented code
- Angel's Petrochem now always disables Bob's Nuclear - Angel's Nuclear is now part of Petrochem, rather than Industries
Recipe has been renamed
We aren't nilling crushed stone so .json migration will not trigger. Purple metal catalysts have never been released so don't need migrating
Factorio 1.1 used to allow either format for specifying technology ingredients (type was shared with recipes)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements only naming changes made by
This does PR is NOT in a running state, it only implements name changes which will not be commented.
PR copied from #349 due to permissions issues or something