-
Notifications
You must be signed in to change notification settings - Fork 24
2.0 logic changes #350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
2.0 logic changes #350
Conversation
…ages to help debugging
- thermal extractor graphics has changed (still need to fix the animations) - Crash when not using bobwarfare - Unnecessary line of code since angels was patched (removing glass from red science recipe) - Somewhat cleaned the dummy lab code
Also fixed a couple bugs
… inventory before startup
394116f to
e948a36
Compare
e948a36 to
1917641
Compare
| end | ||
| end | ||
|
|
||
| -- Adds handcrafting recipes because crafting category "electronics" is no longer craftable by hand |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should rather be handled by the respective mods individually but I'm unsure so I left it in for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do you believe this is necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added all this because otherwise it wouldn't be craftable by hand. I didn't want to change "electronics" to be handcraftable because that would change certain items as well which weren't handcraftable in 1.1.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think any of this is required. These recipes can be crafted by hand. Their crafting category should be crafting. This is the default if a category is not specified. They have electronics in their additional_categories.
|
|
||
| -- Change base game beacon | ||
| data.raw.beacon["beacon"].distribution_effectivity = 1 | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This better fits the 1.1 feel. I'm unsure about this though. It matches the distribution_effectivity of bob-beacon-x below.
|
|
||
| local turbine = data.raw["electric-energy-interface"]["wind-turbine-2"] | ||
| turbine.working_sound.sound.volume = 0.3 | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did this because the turbine was unbearably loud.
| seablock.lib.removeingredient("bob-basic-underground-belt", "wood") | ||
| seablock.lib.removeingredient("bob-basic-splitter", "wood") | ||
|
|
||
| -- Can always apply productivity modules to furnace recipes, so make it official |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is now handled when sb-wood-bricks-charcoal is created.
| set_pvp() | ||
| end) | ||
|
|
||
| script.on_event(defines.events.on_player_created, function(e) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was all duplicate code.
This PR is based on my 2.0 naming changes. It implements all the logic needed to run Sea Block in 2.0. It mostly recreates the 1.1 feel. Any change done by Angels/Bobs which is not listed below is accepted and/or integrated.
Changes: