native_layer: Do a poll during flush to ensure data gets transferred #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gimaker
approved these changes
Oct 31, 2024
dflemstr
force-pushed
the
dflemstr/poll-on-flush
branch
from
a8e58ce to
9a4c8b8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling flush doesn't ensure that the data from the Perfetto SDK is actually written to the output writer. This PR makes sure that a poll happens straight after flush, so that we can "guarantee" that the data appears on the output writer.
This includes a breaking change since we add a parameter to
flush()