-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test vanilla event loop windows #180
Open
freider
wants to merge
15
commits into
main
Choose a base branch
from
freider/test-vanilla-event-loop-windows
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
35f1d03
Repeatedly poll futures instead of infinite wait
freider 647243a
Enable windows and mac tests in ci
freider ae631f8
ruff
freider ed6fc32
skip some tests
freider 13a3d44
Fix tests on windows + fix ctrl-c windows bug for async synchronicity…
freider 57d2ef0
ruff
freider 25690a3
Fix test
freider 74c99f2
ruff
freider 0008483
update ruff
freider 0d0cb81
test flake on mac
freider 5ade25f
Use default event loop instead of overriding, checking to see if it s…
freider bd5abd3
Merge remote-tracking branch 'origin/main' into freider/test-vanilla-…
freider b5c711f
Merge remote-tracking branch 'origin/main' into freider/test-vanilla-…
freider a39223b
Merge remote-tracking branch 'origin/main' into freider/test-vanilla-…
freider 5ecb3cf
Disable gevent test on windows
freider File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tbh, not sure how important gevent support is these days, but maybe there are still libraries making use of it?
I feel I'd rather have synchronicity be on the default event loop implementation to prevent potential inconsistencies of using a different one?