-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add music gen example #1028
Add music gen example #1028
Conversation
🚀 The docs preview is ready! Check it out here: https://modal-labs-examples--frontend-preview-2cda415.modal.run |
how would you expose this functionality through a web-API endpoint with a custom route like "/predict"? |
🚀 The docs preview is ready! Check it out here: https://modal-labs-examples--frontend-preview-64c8dc7.modal.run |
you could do something like this:
|
is it ok if I push a commit to this branch? |
made a PR towards this branch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly minor nits and comments.
I do think we want to avoid replicating the wav-handling code here, cf the comment on L70.
🚀 The docs preview is ready! Check it out here: https://modal-labs-examples--frontend-preview-aebb4a6.modal.run |
🚀 The docs preview is ready! Check it out here: https://modal-labs-examples--frontend-preview-6f563f8.modal.run |
🚀 The docs preview is ready! Check it out here: https://modal-labs-examples--frontend-preview-b5a546f.modal.run |
🚀 The docs preview is ready! Check it out here: https://modal-labs-examples--frontend-preview-8874c05.modal.run |
🚀 The docs preview is ready! Check it out here: https://modal-labs-examples--frontend-preview-a44f069.modal.run |
🚀 The docs preview is ready! Check it out here: https://modal-labs-examples--frontend-preview-eb883b3.modal.run |
2nd PR to split out boombot into 2 diff examples
Type of Change
Checklist
lambda-test: false
is added to example frontmatter (---
)modal run
or an alternativecmd
is provided in the example frontmatter (e.g.cmd: ["modal", "deploy"]
)args
are provided in the example frontmatter (e.g.args: ["--prompt", "Formula for room temperature superconductor:"]
latest
python_version
for the base image, if it is used~=x.y.z
or==x.y
version < 1
are pinned to patch version,==0.y.z
Outside contributors
You're great! Thanks for your contribution.