Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix[2748]: Use setuptools to parse pyproject.toml #2753

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

peterroelants
Copy link

@peterroelants peterroelants commented Jan 12, 2025

Describe your changes

pip_install_from_pyproject: Parse pyproject.toml file using setuptools instead of plain toml to allow to resolve dynamic dependencies.

Backward/forward compatibility checks] ---

Check these boxes or delete any item (or this section) if not relevant for this PR.

  • Client+Server: this change is compatible with old servers
  • Client forward compatibility: this change ensures client can accept data intended for later versions of itself

Note on protobuf: protobuf message changes in one place may have impact to
multiple entities (client, server, worker, database). See points above.


Changelog

@peterroelants
Copy link
Author

Not sure what your contributor guidelines are, and how to test this properly. Any help is appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant