Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass pty correctly in modal shell <task-id> #2725

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

aksh-at
Copy link
Contributor

@aksh-at aksh-at commented Jan 4, 2025

Since exec is decorated with @click.command and we're calling it directly here, pty was getting a weird default value (typer.OptionInfo).

Backward/forward compatibility checks

Check these boxes or delete any item (or this section) if not relevant for this PR.

  • Client+Server: this change is compatible with old servers
  • Client forward compatibility: this change ensures client can accept data intended for later versions of itself

Note on protobuf: protobuf message changes in one place may have impact to
multiple entities (client, server, worker, database). See points above.


Changelog

@aksh-at aksh-at requested a review from mwaskom January 4, 2025 17:42
Copy link
Contributor

@mwaskom mwaskom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably could refactor this a little better at some point.

@aksh-at aksh-at merged commit a8a3103 into main Jan 6, 2025
22 checks passed
@aksh-at aksh-at deleted the akshat/fix-modal-shell-exec branch January 6, 2025 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants