New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spawn should just use the async function call invocation #2644

Open

danielshaar wants to merge 2 commits into main from dshaar/spawn-off-async-legacy

Contributor

danielshaar commented Dec 11, 2024

Describe your changes

SVC-220

Since the server treats it the same as async legacy, this is a NOOP - https://github.com/modal-labs/modal/pull/18139.

Check these boxes or delete any item (or this section) if not relevant for this PR.

Client+Server: this change is compatible with old servers - If the server got reverted to before the new experimental spawn behavior, new clients would fail on inputs between 8KiB and 2MiB.

danielshaar requested a review from gongy

December 11, 2024 20:27

danielshaar added 2 commits

December 12, 2024 18:40


          Spawn should just use the async function call invocation since the se…

3fe994a

…rver treats it the same as async legacy.


          Use async for generators too - even though we're deprecating this.

27796e5

danielshaar force-pushed the dshaar/spawn-off-async-legacy branch 2 times, most recently from d0798c3 to 27796e5 Compare

December 12, 2024 23:02

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet