Use pyright for static type checking of implemenation code #1403
Conversation
| timeout_secs=timeout_secs or 0, | ||
| task_idle_timeout_secs=container_idle_timeout or 0, | ||
| concurrency_limit=concurrency_limit or 0, |
There was a problem hiding this comment.
IIRC there was some discussion recently that container timeouts can't be set to 0. I don't know if that's really a problem here but seems kinda weird.
There was a problem hiding this comment.
These defaults additions were previously implicit due to protobuf's serialization format, since nullity (?) isn't really a thing there unless you box your primitive types in a message type or similar. So for example task_idle_timeout_secs is currently determined to be unset by the backend when it's 0, which isn't great since it prevents us from setting an actual 0-value. According to the docs we have a minimum value of 2 seconds, which is arguably even weirder :D
|
Yeah it's not very pretty. Perhaps we can refactor the code at some point to make a few of the "connected" types like But this should at least not lead to any errors that weren't previously errors further down the call stack :) |
| @@ -19,7 +19,7 @@ packages = find: | |||
| python_requires = >=3.8 | |||
| install_requires = | |||
| aiohttp | |||
| aiostream | |||
There was a problem hiding this comment.
This shouldn't trigger image rebuilds right @mwaskom ? Afaicr only the modal/requirements.txt file does that 🤔
|
@freider Interesting, I didn't realize One thought - |
|
@prbot approve |
![modal-pr-review-automation[bot]](https://avatars.githubusercontent.com/in/335990?s=60&v=4){kind=small}
mypy can not and will not get functionality to be able to type check files that have both implemenation and type stubs (both .py and .pyi files). Pyright does seem to support it, so this adds it to the CI pipeline for checking implemenations.
This only adds
functions.pyto the whitelist of files to test, since it's quite an undertaking to fix all of the client code at once. Once we have fixes for all files we can let pyright traverse the entire repo instead of using this whitelist.If I understand things correctly, pyright is also what's used as the python language server by vscode, so getting rid of type warnings for vscode devs is another benefit.
Initial batch of fixes for: #1372 and MOD-2387