fix: set test total properly with --fail-zero and --delay #5057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running --fail-zero along with --delay exit with code 0 if at least one test runs.
JoshuaKGoldberg
requested changes
Mar 4, 2024
There was a problem hiding this comment.
[Testing] The change looks functionally good, but we'll want to add a test to ensure it both works now & stays working in the future. Could you please?
JoshuaKGoldberg
added
status: waiting for author
JoshuaKGoldberg
changed the title
|
👋 ping @joandino, is this still something you have time for? |
|
Closing out as it's been a while since PR activity. If anybody wants to take this over, please do - and post a co-author attribution if you take code from this PR. Cheers! 🤎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
status: accepting prsDescription of the change
When running --fail-zero along with --delay the result always return 1 even when at least one test runs.
Apparently the total variable in the runner was not being updated after the event delay ends and the tests runs.
On the emit of the
EVENT_DELAY_ENDwe make sure to update the total of tests ran.Why should this be in core?
To prevent tests that run with
--fail-zeroand--delayalways fail.Applicable issues
This will be a fix/patch release