Skip to content

appcontext/tracing: make InitContext public #4548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
laurazard wants to merge 1 commit into from
Closed

appcontext/tracing: make InitContext public #4548

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions util/tracing/env/traceenv.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,10 @@ const (
)

func init() {
appcontext.Register(initContext)
appcontext.Register(InitContext)
}
Comment on lines 16 to 18
Copy link
Member

@thaJeztah thaJeztah Jan 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wondering if we need to keep the init, as that would be dead-code if appcontext is not used (but it will remain a dependency due to it being imported) 🤔

(have not looked how / where it's imported though).

Copy link
Member Author

@laurazard laurazard Jan 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I thought about making other changes to appcontext/this package for that but had concerns about that possibly silently breaking things for other downstream users. If we do that, we should do that together with other changes to make sure we don't silently break, or clearly call it out.

Copy link
Member Author

@laurazard laurazard Jan 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(side note, but I really hate inits for this reason, it's much harder to reason about and figure out the blast radius of changes like this)


func initContext(ctx context.Context) context.Context {
func InitContext(ctx context.Context) context.Context {
// open-telemetry/opentelemetry-specification#740
parent := os.Getenv("TRACEPARENT")
state := os.Getenv("TRACESTATE")
Expand Down