fix: prevent data race in some occasions #3862
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: skrtheboss <[email protected]>
|
All tests are passing on my fork skrtheboss#1 |
|
Thanks for this. These do need to be all separately validated so that there isn't a performance regression or a deadlock. If some of them are simpler to reason about than others, feel free to open separate PRs for them so they can potentially get reviewed quicker. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All fixed data races have been observed by using the
-racego utility.Originally my buildkit deamon was crashing due to a very similar error as reported on #2041, so I started debugging and found some other race conditions and now my log is clean, no more
WARNING: DATA RACEmessage.I am not sure if the approach I used is correct, just let me know if I need to change something.