Fix typo in 'soruce.http.uidgid' #3425
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ben Longo <[email protected]>
AkihiroSuda
reviewed
Dec 17, 2022
| @@ -33,7 +33,7 @@ const ( | |||
| CapSourceHTTP apicaps.CapID = "source.http" | |||
| CapSourceHTTPChecksum apicaps.CapID = "source.http.checksum" | |||
| CapSourceHTTPPerm apicaps.CapID = "source.http.perm" | |||
| CapSourceHTTPUIDGID apicaps.CapID = "soruce.http.uidgid" | |||
| CapSourceHTTPUIDGID apicaps.CapID = "source.http.uidgid" | |||
There was a problem hiding this comment.
Suggested change
| CapSourceHTTPUIDGID apicaps.CapID = "source.http.uidgid" | |
| CapSourceHTTPUIDGID apicaps.CapID = "source.http.uidgid" | |
| CapSourceHTTPUIDGIDTypo apicaps.CapID = "soruce.http.uidgid" // typo (v0.3 - v0.11), but unremovable for maintaining compatibility |
The typo cap must also remain enabled (see https://github.com/moby/buildkit/search?q=CapSourceHTTPUIDGID to find the code that has to be updated)
crazy-max
requested changes
Jan 30, 2023
There was a problem hiding this comment.
@benlongo Can you make the change suggested by @AkihiroSuda? Otherwise LGTM.
|
Ping @benlongo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I doubt it is possible to directly change this because it's a public API, but I'm unsure how that should be done. This PR is here mostly just to bring attention to the issue and discuss possible resolutions.