Skip to content

Fix drawer close and logo keyboard regressions#91

Merged
hamzamerzic merged 2 commits into
mainfrom
fix/navigation-drawer-regressions
Jul 18, 2026
Merged

Fix drawer close and logo keyboard regressions#91
hamzamerzic merged 2 commits into
mainfrom
fix/navigation-drawer-regressions

Conversation

@hamzamerzic

Copy link
Copy Markdown
Collaborator

Summary

  • consume the Shift+Enter logo mode activation so it does not also toggle navigation
  • keep the mobile drawer scrim blocking until the closing panel is actually offscreen
  • make workspace drag release flush the final coalesced move before committing
  • tighten navigation/workspace E2E assertions for persistent desktop sidebar and real pane-center drops

Validation

  • node --test frontend/src/components/Shell/tests/workspaceUi.test.js frontend/src/components/Shell/tests/mobileDrawerClose.test.js
  • scripts/playwright-local.sh --allow-local-e2e tests/workspace-panes.spec.mjs tests/navigation.spec.mjs --project=tests --grep "logo gesture flips|single-mode drag|Closing scrim|breakpoint cleanup"

@hamzamerzic
hamzamerzic force-pushed the fix/navigation-drawer-regressions branch from 95c8cf0 to d65ff03 Compare July 18, 2026 20:02
@hamzamerzic
hamzamerzic merged commit 36fcccb into main Jul 18, 2026
14 checks passed
@hamzamerzic
hamzamerzic deleted the fix/navigation-drawer-regressions branch July 18, 2026 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant