Skip to content

Stop disclosure collapse viewport bounce#83

Closed
hamzamerzic wants to merge 8 commits into
mainfrom
fix/stop-collapse-viewport-bounce
Closed

Stop disclosure collapse viewport bounce#83
hamzamerzic wants to merge 8 commits into
mainfrom
fix/stop-collapse-viewport-bounce

Conversation

@hamzamerzic

@hamzamerzic hamzamerzic commented Jul 16, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • reserve a closing disclosure body's height synchronously so bottom-clamped chats do not paint a down/up twitch
  • distinguish disclosure taps from real reader scroll gestures while retaining touch-drag ownership
  • cover spacer priming, opening behavior, and disclosure input classification

The branch contains #82 as ancestry so its full suite can run in parallel; after #82 lands, this PR naturally reduces to the one follow-up commit.

Review

  • reviewed against all ActivityStretch, ToolBlock, and MarkerCard disclosure DOM shapes
  • verified the dynamic spacer remains owned by the existing ResizeObserver after the provisional adjustment
  • preserved real touchmove ownership and ordinary pointer/touch behavior

Verification

  • npm test (1,096 frontend/lib tests + 44 hook tests)
  • npm run build
  • focused production-tree suite: 62 tests

@hamzamerzic
hamzamerzic changed the base branch from fix/land-prod-local-edits to main July 16, 2026 19:13
@hamzamerzic hamzamerzic reopened this Jul 16, 2026
@hamzamerzic
hamzamerzic force-pushed the fix/stop-collapse-viewport-bounce branch from a31b67f to af7be92 Compare July 16, 2026 19:15
@hamzamerzic

Copy link
Copy Markdown
Collaborator Author

Superseded after concurrent landing: main now contains this PR's disclosure-collapse fix as fb22aa9. The remaining stacked drawer/service/test changes were reconciled onto current main in #82, avoiding duplicate commits and conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant