Surface native Codex image views - #277
Conversation
Co-authored-by: Möbius Agent <mobius-agent@users.noreply.github.com>
|
I found a merge-blocking runtime type issue while validating this PR.
Before merge, the provider adapter should normalize that field into Möbius’s plain-JSON event domain, for example: "input": _model_dump(getattr(item, "path", "")),The contract test should instantiate the real generated item rather than a string-valued fake and prove the entire event round-trips through item = v2_all.ImageViewThreadItem(
id="image-1", path="/tmp/diagram.png", type="imageView",
)
event = codex_sdk_runner._tool_start_event(item, codex_sdk_runner._sdk_imports())
assert event["input"] == "/tmp/diagram.png"
assert json.loads(json.dumps(event)) == eventI reproduced the failure end to end and verified this conversion against the installed SDK type. |
|
Merged to main as part of #304. Native Codex image views are now included in the integrated default-branch change. |
Summary
ImageViewThreadItemViewImageactivity used by the transcriptTests
MOBIUS_TEST_RUNTIME=1 pytest -q backend/tests/test_codex_sdk_contract.py backend/tests/test_codex_sdk_runner.py -q