Resolve Three addons from the pinned app runtime - #120
Closed
hamzamerzic wants to merge 1 commit into
Closed
Conversation
Collaborator
Author
|
Two review rounds complete on exact head |
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
three/addons/*spelling to Three’s pinned physicalexamples/jsmdirectory before the root package aliasProduction evidence
Forge (app 74) fails every boot-time compiled-runtime reconciliation because the root alias currently bypasses Three’s package-export mapping. The running app keeps its previous bundle, but never reaches artifact revision 3.
Tests
docker run ... pytest -q backend/tests/test_runtime_libs.py backend/tests/test_app_compile_contract.py(13 passed)git diff --check