You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Independent exact-head review (fef458b422f608d88c288005eb82d301f867edb0): hold merge pending two fixes.
ModelPicker renders its position:absolute; inset:0 backdrop inside .mobius-agent-priority-row (a positioned/transform stacking context). The backdrop is row-bounded and the sheet cannot reliably cover/dismiss across the app. Clean production already contains the missing follow-up: portal the sheet to document.body (1c3aa0f, with regression test 59e0dad). Please bring that fix here while retaining this PR's stronger triggerLabel and aria-pressed semantics.
The reorder is not identity-preserving when either row inherits Settings. primary_agent_mode: system resolves system choice 0, while secondary_agent_mode: system resolves system choice 1. Example: [system primary A, app override C] is swapped by the UI into [app C, system secondary B], not [C, A]; [system A, system B] is a no-op. Because News persists the swap immediately, this can durably save a different agent set than the drag preview promises. Either materialize the resolved inherited choices when reordering, add a stable source/order contract, or disable/clarify reorder for inherited rows.
Follow-up quality: the drag handles are named only by ordinal (Move background agent priority 1/2), unlike Settings' provider-named handles, and there is no reorder announcement. Please include agent identity and an aria-live result if this remains draggable.
Verified: exact head is clean/mergeable with green CI; npm test 84/84; current platform validate-app.py 0 errors/0 warnings; manifest/version/source-file/bundle closure and git diff --check pass. News' immediate durable-write, superseded-response guard, rollback, and same-agent warning remain intact.
Post-merge exact-head closure: I rechecked final 517b7ced97fc38a511de701219f3ceb4baa9fad7 after the requested fixes. The picker is body-portaled; inherited rows cannot perform identity-changing reorder; and drag handles/live announcements identify the affected agents. News still preserves its immediate durable-write, superseded-response, rollback, and same-agent warning contracts. Final validation: 85 tests passed. The earlier hold is fully resolved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
npm test— 84/84 passedvalidate-app.py— 0 errors, 0 warningsgit diff --check