ICD revalidation

[metinbicer]

No description provided.

[AKuederle]

Nice! Some first small comments. More tomorrow :)

[AKuederle]

Some comments to the revalidation scripts

[AKuederle]

Aah and you need to add the new files to the documentation:

• Reval scripts: https://github.com/mobilise-d/mobgap/blob/initial_contact_reval/docs/conf.py
• New eval funcs: https://github.com/mobilise-d/mobgap/blob/initial_contact_reval/docs/modules/initial_contacts.rst

(See GSD as example: https://github.com/mobilise-d/mobgap/blob/initial_contact_reval/docs/modules/gait_sequences.rst)

[AKuederle]

Aah and you need to add the new files to the documentation:

• Reval scripts: https://github.com/mobilise-d/mobgap/blob/initial_contact_reval/docs/conf.py
• New eval funcs: https://github.com/mobilise-d/mobgap/blob/initial_contact_reval/docs/modules/initial_contacts.rst

(See GSD as example: https://github.com/mobilise-d/mobgap/blob/initial_contact_reval/docs/modules/gait_sequences.rst)

Note, that the pipeline will fail if you do this unless you also change the branch name here:

mobgap/revalidation/initial_contacts/_01_icd_analysis.py

Line 65 in b7e380f

"icd", result_path=local_data_path, version="main"

[AKuederle]

Looks good! Please double check if it is coprrect to use the "detected" not the reference in calculate_true_positive_icd_error. I think this is not correct.

All other stuff are small minor fixes.

Note, that I made some updates while reviewing. Make sure you pull; before making further changes!

[AKuederle]

Merged! Awesome @metinbicer