Proposta solucao do desafio, Larissa Ester. #61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolucao de problemas e melhorias do projeto propostas:
Perda do estado de tela: Solucao Uso de view model e livedata
Crashes por nulos e ciclo de vida: Tratamento de erros e coroutines no viewModel
Falta de cache: Room Database para armazenar usuarios
Codigo dificil de manter(negocio): Separacao em Repository e viewmodel (clean arch)
Codigo dificil de manter(apresentacao)Uso de DiffUtil e data binding
Testes: Uso de hilt para permitir testes e implementados testes unitarios e de intrumentacao.
Utilizado Clean Architecture, princípios SOLID, Clean Code, ViewModel + LiveData, Room + Retrofit, Hilt para DI e RecyclerView com DiffUtil. Garantido baixo acoplamento, alta coesão, testabilidade e escalabilidade.