Made control scheme more robust #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added the ability to tap to move the character in addition to the original touchscreen method of dragging across the screen. The two methods do not interfere with each other. Lowered the minSdkVersion to allow the application to install on 2.1. I did not notice any issues on my 2.1 device.
The player can now teleport into any location it would have been possible for them to move to without pushing any diamonds. Pushing a diamond via tapping is now only possible if player is adjacent to a diamond. This still does not affect swiping/dragging in any way.
Certain screens would register move events for even the lightest tap, which made tapping to move not work on all devices.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I first downloaded this application, I found the control scheme somewhat frustrating and difficult to use, and decided to try to add additional movement options. I was impressed with the simplicity of the code base, which made adding these changes quite simple.
The original control scheme is completely unaffected; this is purely an additional way to move the character. Instead of only allowing movement by dragging, now the player can tap in an empty square that the character has access to. Any invalid square, when tapped, does nothing. If the player is adjacent to a diamond, then tapping the diamond moves it if there's nothing on the opposite side of it.
I also reduced the minSDKVersion because I have an Android 2.1 device and was curious if there were any issues for it. The application seems to run perfectly fine on 2.1, and the version of this on the market seems to also be 2.1-compatible.
There were also a few autogenerated files that changed when I imported the project into Eclipse. I don't know what the common practice is for files like this, as I'm new to contributing to open-source projects. I would have told Git to ignore them if I had thought longer about the first commit.
If you are still actively maintaining this repo, I hope you consider merging this minor change into the main branch, so it can be updated on F-Droid and the Android market. I think it makes the game more precise and fun to play, and that players can benefit from it.