-
Notifications
You must be signed in to change notification settings - Fork 296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add configuration file parameter to test, cloud and record commands #1829
Add configuration file parameter to test, cloud and record commands #1829
Conversation
this is a better approach!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, thanks a lot! I can see this being quite useful, and it doesn't increase code complexity a lot.
requesting further review from @amanjeetsingh150
...o-orchestra/src/test/java/maestro/orchestra/workspace/WorkspaceExecutionPlannerErrorsTest.kt
Outdated
Show resolved
Hide resolved
maestro-orchestra/src/main/java/maestro/orchestra/workspace/WorkspaceExecutionPlanner.kt
Outdated
Show resolved
Hide resolved
maestro-orchestra/src/main/java/maestro/orchestra/workspace/WorkspaceExecutionPlanner.kt
Outdated
Show resolved
Hide resolved
maestro-orchestra/src/test/resources/workspaces/014_config_not_null/config/another_config.yml
Outdated
Show resolved
Hide resolved
maestro-orchestra/src/test/resources/workspaces/014_config_not_null/flowB.yaml
Outdated
Show resolved
Hide resolved
maestro-orchestra/src/test/resources/workspaces/014_config_not_null/config.yml
Outdated
Show resolved
Hide resolved
2dc4a29
to
9db19c2
Compare
The failing test is a false positive caused by #2005 |
@bartekpacia Thanks for addressing the review comments in the pr, I didn't have much time to go through them |
Proposed changes
The idea behind this PR is to allow multiple configurations for the same test suite. This comes really handy when having the same app with multiple flavors/schemas: you can run the same test on apps having the same codebase but different flows.
This changes add a new parameter
--config
to the following commands:$ maestro cloud
$ maestro test
$ maestro record
The parameter is a path for the configuration file used for the flows.
Examples of use:
$ maestro test --config config/another_config.yml
Testing
$ maestro test --config your_path_to_the_config/file.yml