Rename InstallAppCommand

mobile-dev-inc · Aug 29, 2024 · f0965b2 · f0965b2
1 parent 396aafb
commit f0965b2
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 8 deletions.
diff --git a/maestro-orchestra-models/src/main/java/maestro/orchestra/Commands.kt b/maestro-orchestra-models/src/main/java/maestro/orchestra/Commands.kt
@@ -951,7 +951,7 @@ data class ToggleAirplaneModeCommand(
     }
 }
 
-data class InstallApplicationCommand(
+data class InstallAppCommand(
     val path: String? = null,
     val label: String? = null,
 ): Command {

diff --git a/maestro-orchestra-models/src/main/java/maestro/orchestra/MaestroCommand.kt b/maestro-orchestra-models/src/main/java/maestro/orchestra/MaestroCommand.kt
@@ -67,7 +67,7 @@ data class MaestroCommand(
     val addMediaCommand: AddMediaCommand? = null,
     val setAirplaneModeCommand: SetAirplaneModeCommand? = null,
     val toggleAirplaneModeCommand: ToggleAirplaneModeCommand? = null,
-    val installApplicationCommand: InstallApplicationCommand? = null,
+    val installAppCommand: InstallAppCommand? = null,
 ) {
 
     constructor(command: Command) : this(
@@ -110,7 +110,7 @@ data class MaestroCommand(
         addMediaCommand = command as? AddMediaCommand,
         setAirplaneModeCommand = command as? SetAirplaneModeCommand,
         toggleAirplaneModeCommand = command as? ToggleAirplaneModeCommand,
-        installApplicationCommand = command as? InstallApplicationCommand,
+        installAppCommand = command as? InstallAppCommand,
     )
 
     fun asCommand(): Command? = when {
@@ -153,7 +153,7 @@ data class MaestroCommand(
         addMediaCommand != null -> addMediaCommand
         setAirplaneModeCommand != null -> setAirplaneModeCommand
         toggleAirplaneModeCommand != null -> toggleAirplaneModeCommand
-        installApplicationCommand != null -> installApplicationCommand
+        installAppCommand != null -> installAppCommand
         else -> null
     }
 

diff --git a/maestro-orchestra/src/main/java/maestro/orchestra/Orchestra.kt b/maestro-orchestra/src/main/java/maestro/orchestra/Orchestra.kt
@@ -286,7 +286,7 @@ class Orchestra(
             is AddMediaCommand -> addMediaCommand(command.mediaPaths)
             is SetAirplaneModeCommand -> setAirplaneMode(command)
             is ToggleAirplaneModeCommand -> toggleAirplaneMode()
-            is InstallApplicationCommand -> installApp(command)
+            is InstallAppCommand -> installApp(command)
             else -> true
         }.also { mutating ->
             if (mutating) {
@@ -295,7 +295,7 @@ class Orchestra(
         }
     }
 
-    private fun installApp(command: InstallApplicationCommand): Boolean {
+    private fun installApp(command: InstallAppCommand): Boolean {
         maestro.installApp(command.path)
 
         return true

diff --git a/maestro-orchestra/src/main/java/maestro/orchestra/yaml/YamlFluentCommand.kt b/maestro-orchestra/src/main/java/maestro/orchestra/yaml/YamlFluentCommand.kt
@@ -246,7 +246,7 @@ data class YamlFluentCommand(
             toggleAirplaneMode != null -> listOf(MaestroCommand(ToggleAirplaneModeCommand(toggleAirplaneMode.label)))
             installApp != null -> listOf(
                 MaestroCommand(
-                    InstallApplicationCommand(
+                    InstallAppCommand(
                         path = installApp.path,
                         label = installApp.label
                     )

diff --git a/maestro-test/src/test/resources/116_install_app.yaml b/maestro-test/src/test/resources/116_install_app.yaml
@@ -1,3 +1,4 @@
 appId: com.example.app
 ---
-- installApp: "maestro-client/src/main/resources/maestro-app.apk"
+- installApp:
+    "maestro-client/src/main/resources/maestro-app.apk"