Skip to content
This repository has been archived by the owner on Aug 5, 2020. It is now read-only.

iOS8-specific Fixes #95

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from
Open

iOS8-specific Fixes #95

wants to merge 7 commits into from

Conversation

marlowpayne
Copy link

Reviewers: @fractaltheory @MikeKlemarewski @jansepar @mikenikles

Changes

  • Opening a PR for this fix's visibility
  • The same fix can be seen on the eddie-bauer branch (develop...eddie-bauer) so this seems like a common-enough issue to fix in mainline

Todos:

  • Determine if this is a worthwhile fix for mainline
  • +1

mlworks and others added 5 commits October 7, 2015 17:49
@mlworks
[iOS8+] Fix scroll position when opening pinny
f6030e1 
Lockup scrolls the lockup container but we'll need to set the page
position to the top so the page would appear exactly where you left
off. This bug can be easily seen when you have a Pinny with low
coverage area set. HEB-172 bug for reference.
@mlworks
build files
f4d862f
@vmarta
Merge branch 'master' into scrolltop-fix
25f2857 
Conflicts:
	dist/effect/modal-center.min.js
	dist/effect/sheet-bottom.min.js
	dist/effect/sheet-left.min.js
	dist/effect/sheet-right.min.js
	dist/effect/sheet-top.min.js
	dist/pinny.js
	dist/pinny.min.js
	src/js/pinny.js
@mlworks
Force window repaint when opening Pinny
ead045c 
Fix iOS8 issue where Pinny wouldn't render correctly if the user
doesn't scroll the page at all.
@mlworks
committing build files
f3ae6be
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
Ready for Review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marlowpayne @mlworks @vmarta