Skip to content

Conversation

@spollard
Copy link

Updated clang version to 9.
I clicked around a bit to make sure things worked, but not major testing.

@ocdtrekkie
Copy link
Contributor

One other fun thing: You may want to clean all of the bin/, lib/, and lib64/ items from the sandstorm-files.list file, since bin, lib, and lib64 are all now symlinks now (do not delete them), but the files under them are not. See sandstorm-io/sandstorm#3535

@ocdtrekkie
Copy link
Contributor

You won't see the issue until you try to pack the SPK, but I would delete:

bin/bash
bin/cp
bin/dash
bin/df
bin/mkdir
bin/rm
bin/sh

lib/x86_64-linux-gnu/libacl.so.1
lib/x86_64-linux-gnu/libattr.so.1
lib/x86_64-linux-gnu/libblkid.so.1
lib/x86_64-linux-gnu/libblkid.so.1.1.0
lib/x86_64-linux-gnu/libbsd.so.0
lib/x86_64-linux-gnu/libbz2.so.1.0
lib/x86_64-linux-gnu/libbz2.so.1.0.4
lib/x86_64-linux-gnu/libc.so.6
lib/x86_64-linux-gnu/libcom_err.so.2
lib/x86_64-linux-gnu/libcom_err.so.2.1
lib/x86_64-linux-gnu/libdbus-1.so.3
lib/x86_64-linux-gnu/libdl.so.2
lib/x86_64-linux-gnu/libexpat.so.1
lib/x86_64-linux-gnu/libgcc_s.so.1
lib/x86_64-linux-gnu/libgcrypt.so.20
lib/x86_64-linux-gnu/libglib-2.0.so.0
lib/x86_64-linux-gnu/libgpg-error.so.0
lib/x86_64-linux-gnu/libkeyutils.so.1
lib/x86_64-linux-gnu/liblzma.so.5
lib/x86_64-linux-gnu/libm.so.6
lib/x86_64-linux-gnu/libmount.so.1
lib/x86_64-linux-gnu/libmount.so.1.1.0
lib/x86_64-linux-gnu/libnsl.so.1
lib/x86_64-linux-gnu/libnss_compat.so.2
lib/x86_64-linux-gnu/libnss_dns.so.2
lib/x86_64-linux-gnu/libnss_files.so.2
lib/x86_64-linux-gnu/libpcre.so.3
lib/x86_64-linux-gnu/libpcre.so.3.13.3
lib/x86_64-linux-gnu/libpthread.so.0
lib/x86_64-linux-gnu/libresolv.so.2
lib/x86_64-linux-gnu/librt.so.1
lib/x86_64-linux-gnu/libselinux.so.1
lib/x86_64-linux-gnu/libsystemd.so.0
lib/x86_64-linux-gnu/libutil.so.1
lib/x86_64-linux-gnu/libuuid.so.1
lib/x86_64-linux-gnu/libuuid.so.1.3.0
lib/x86_64-linux-gnu/libz.so.1

lib64/ld-linux-x86-64.so.2

@spollard
Copy link
Author

OK I made those changes!

I see that opt/app/sandstorm-integration/bin/getPublicId has been removed from sandstorm-files.list. I'm guessing that'll be added back when sandstorm-files.list is updated at release time?

@mnutt
Copy link
Owner

mnutt commented Jul 25, 2022

Awesome, thank you for this! Looks great at first glance.

IIRC the getPublicId binary is necessary for publishing grains, but yeah I can exercise that functionality before release to make sure it gets added back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants