Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Update install.rst to reflect pyproject.toml #180

Merged
merged 3 commits into from
Apr 21, 2024

Conversation

JonathanShor
Copy link
Contributor

Thanks for contributing. If this is your first time,
make sure to read contributing.md

PR Description

Updates the Installation docs page to reflect the current pyproject.toml defined dependencies.

Merge checklist

Maintainer, please confirm the following before merging:

  • All comments resolved
  • This is not your own PR
  • All CIs are happy
  • PR title starts with [MRG]
  • whats_new.rst is updated
  • PR description includes phrase "closes <#issue-number>"

@adam2392
Copy link
Member

I think the CI issue arises from sphinx version I guess?

@larsoner have you seen this error before?

@larsoner
Copy link
Member

the short term solution is

https://github.com/mne-tools/mne-python/blob/156ae18572c8322ae75c964258f3fdc607006587/doc/conf.py#L809

the long term solution is

sphinx-gallery/sphinx-gallery#1289

and other conf.py changes

Signed-off-by: Adam Li <[email protected]>
Copy link
Member

@adam2392 adam2392 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once CI gets fixed

Signed-off-by: Adam Li <[email protected]>
@adam2392 adam2392 merged commit 18e1181 into mne-tools:main Apr 21, 2024
9 checks passed
@adam2392
Copy link
Member

Thanks @JonathanShor !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants