fixup for TWA-HP (gh1043) #1055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larsoner
approved these changes
Feb 19, 2025
drammock
commented
Feb 19, 2025
There was a problem hiding this comment.
- adds forgotten changelog entry from add framework for TWA head pos as MF destination #1043
- reverts some crufty changes to
_03_maxfilter - remove
runfrom the API ofcompute_twa_head_pos(hopefully makes it clearer that it operates across all runs)
Comment on lines
+158
to
+161
| runs_tasks = get_runs_tasks( | ||
| config=cfg, subject=subject, session=session, which=("runs",) | ||
| )[0] | ||
| ) | ||
| run = next(filter(lambda run_task: run_task[1] == task, runs_tasks))[0] |
There was a problem hiding this comment.
previously there was a possibility that runs_tasks[0][0] might be a run that wasn't present for the current task; this should correct that.
There was a problem hiding this comment.
changes to this file just revert to what it was like before #1043; it's cruft because I initially implemented TWA-HP in this file but then later moved it to _02_headpos so these changes were no longer needed.
| @@ -313,7 +312,6 @@ def main(*, config: SimpleNamespace) -> None: | |||
| subject=subject, | |||
| session=session, | |||
| task=config.task or None, # default task is "" | |||
| run=None, | |||
There was a problem hiding this comment.
no need to pass in run here as it's never used
|
argh, osf.io is having a bad day :( |
|
failure appears real (finally!) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before merging …
docs/source/dev.md.inc)