Split Express entrypoint into focused modules#8
Merged
Conversation
aa328d1 to
50bcdf2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/express.tsas the public facade andcreateDual402entrypointsrc/types.tssrc/config.tssrc/charge.tspaidRoute,dualDiscovery, and OpenAPI generation intosrc/discovery.tsWhy
This applies the maintainability review finding that
src/express.tshad crossed 1k lines and mixed public API, config validation, payment middleware, and discovery generation in one file. The PR is intentionally mechanical so behavior and public imports stay stable.The current handler metadata coupling and cast-heavy x402 shape probing are left unchanged for follow-up PRs.
Verification
npm run checknpm audit --omit=devnpm pack --dry-run