Fix NAN bug when MLT propose a path with 0 radiance #477
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In MLTIntegrator::Render(), when computing radiance for current path and proposed path, there is a non zero probabilty that their radiance (
cCurrent,cProposed) evaluated to 0.In such case, both
acceptand splat value will be affected:acceptwill be assigned1whencCurrent == 0LProposed * accept / cProposedandLCurrent * (1 - accept) / cCurrentwill be evaluated to NAN, thus pollute the final imageMy proposed fix is simple: just avoid
film.AddSplat()whencCurrent == 0 || cProposed == 0, and then computeacceptaccordingly.