drop the rollup node-gyp action and add a prepare script (#216)

* drop the rollup node-gyp action and add a prepare script * remove unintended commit
mmomtchev · Jan 15, 2025 · 84373c4 · 84373c4
1 parent 03a6d3e
commit 84373c4
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 16 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -10,6 +10,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
  - Update avcpp to 2.4.1
  - Apple ARM prebuilt binaries
  - Support rebuilding on Ubuntu 24.04
+ - Fix rebuilding when installing from npm
 
 # [1.0.0] 2024-01-26
  - Add `streams/Filter` to support ffmpeg filters

diff --git a/binding.gyp b/binding.gyp
@@ -42,21 +42,6 @@
           ],
           'destination': '<(module_path)'
         }
-      ],
-      'actions': [
-        {
-          'action_name': 'rollup',
-          'inputs':  [ 'src/lib/Stream.ts' ],
-          'outputs': [ './stream.js' ],
-          'conditions': [
-            ['OS != "win"', {
-              'action': [ 'npx', 'rollup', '-c', 'rollup.config.js' ]
-            }],
-            ['OS == "win"', {
-              'action': [ 'cmd', '/c"npm run rollup"' ]
-            }]
-          ]
-        }
       ]
     }
   ]

diff --git a/package.json b/package.json
@@ -10,7 +10,7 @@
     "test": "npx mocha",
     "lint": "bash -c \"clang-format -i src/binding/*.{cc,h}\" && eslint --fix src/lib/*.[jt]s test/*.[jt]s",
     "clean": "node-pre-gyp clean && tsc --build --clean",
-    "rollup": "npx rollup -c rollup.config.js",
+    "prepare": "npx rollup -c rollup.config.js",
     "preversion": "npm run lint && npm run test",
     "postversion": "git push && git push --tags && node ./scripts/publish-packages.js",
     "postpublish": "gh workflow run test-npm.yml -F version=$npm_package_version"