Selectioncity #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved to ICAROS
It is duplicated with a namedtuple
They have been moved to ICAROS
It used a trivial function that was removed
An "s" was missing
The name was too similar to hits_io and caused confusion
It used a try/except clause that doesn't make sense for non-variable data.
next-exp#707 Note: - `system_of_units_c` has been replaced by `system_of_units`. Replace `from invisible_cities.core.system_of_units_c import units` by `import invisible_cities.core.system_of_units as units`. - `hist_io` has been renamed to `histogram_io`. - Some functions in the folder `icaro` will be moved to the `ICAROS` repository. - `Olivia` related stuff are in the `Olivia` repository. - Old corrections have dissapeared. `corrections_new` renamed to `corrections`. [author: gonzaponte] This PRs goes for an exhaustive cleanup of the repository (at least that's what I tried). Among others, the changes are: - Remove histogram functions for monitoring. - Remove monitor functions. - Remove unnecessary Cython stuff. - Remove unused and deprecated parts of the code. - Remove old corrections and rename corrections_new to corrections. - Fix imports across the repo. - Fix repeated test names. - Remove unused variables across the repo. - Remove some duplicities. - Move get_mc_info to mcinfo_io. - Rename hist_io to histogram_io. Most of the stuff deleted has been moved to another repo so it is not completely lost, but at least we keep IC clean. [reviewer: paolafer] This PR simplifies the IC structure, eliminating obsolete code and doing cosmetics fixes. Overall it is a long-due, very nice clean-up! The only caveat, which will be addressed separately, is that some of the eliminated functions could be used in the analysis. They will be moved to a more appropriate place.
Done to avoid compatibility issues between pandas versions
[author: aretno] The use of read_hdf function as it is fails in higher pandas versions. This uses the standard IC function to load dataframes to discouple the version problem from beersheba city. [reviewer: mmkekic] This PR fixes the reader of psf_file that was doomed to fail in more recent pandas version. Good job, we are one step closer to updating our environment!
Rewrite .gitignore file removing duplicates and adding a few new entries.
[author: jmalbos] Rewrite of the .gitignore file removing redundancies and adding a few new entries. [reviewer: gonzaponte] A better .gitignore file. Good job.
next-exp#743 [author: carmenromo] This PR includes the values for the gains corresponding to the new calibrations with sensL SiPMs in Demo++. Pdfs have been uploaded too. [reviewer: jmbenlloch] Latest calibration correctly included with all tests passing. Approved!
[author: carmenromo] This PR includes the latest sensor calibrations from run 8151. Database has been uploaded with the PMT and SiPMs gains and the pdf values. Apparently sensor 15060 is dead, so it has been masked. [reviewer: jmbenlloch] Latest calibration added. Approved!
next-exp#745 [author: jmalbos] Update NEXT100 local db after bug fix changing SiPM positions [reviewer: jmbenlloch] Fixes the NEXT100 database with the correct SiPM positions.
next-exp#746 [author: carmenromo] This PR adds the gain values of the sensors modified with the ratios between every dice board and the dice board 1 to the DEMOPP database. The min run is 1008744 and the max run 1999999. [reviewer: neuslopez] Correction using qmax added. All tests passed successfully.
next-exp#747 [author: carmenromo] In the last DEMO++ db related PR, correction using qmax was added only for the SiPMs. This PR, updates the PMTs max run to avoid errors when executing the cities for high run numbers. [reviewer: neuslopez] All tests passed successfully.
next-exp#748 [author: carmenromo] This PR increases the maximum run number of the sensors up to 1999999 for the ChannelMapping and ChannelPosition tables of the database. [reviewer: neuslopez] Increased max run in ChannelPosition and ChannelMapping. All tests passed successfully.
next-exp#750 [author: carmenromo] Update new max run for all PMT tables in DEMOPP database. [reviewer: neuslopez] All tests passed!
jerenner
force-pushed
the
selectioncity
branch
from
cada5ca to
e5d93f0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
13 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creates selectioncity, which filters output of Penthesilea by event number. The events to be selected are specified in a .txt file.