-
Notifications
You must be signed in to change notification settings - Fork 1
Add in-memory artifact support #60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
mmacy
wants to merge
2
commits into
dev
Choose a base branch
from
codex/add-support-for-in-memory-artifacts
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| """Utility for bundling course artifacts into an in-memory ZIP archive.""" | ||
|
|
||
| from __future__ import annotations | ||
|
|
||
| import io | ||
| from zipfile import ZipFile, ZIP_DEFLATED | ||
| from dataclasses import dataclass | ||
| from typing import Optional | ||
|
|
||
|
|
||
| @dataclass | ||
| class InMemoryCoursePack: | ||
| """Container for all course artifacts stored as a ZIP file in memory.""" | ||
|
|
||
| zip_bytes: bytes | ||
|
|
||
| @classmethod | ||
| def from_course(cls, course: "Course") -> "InMemoryCoursePack": | ||
| """Create a zip of course JSON, image, and audio stored in memory.""" | ||
| buffer = io.BytesIO() | ||
| with ZipFile(buffer, "w", ZIP_DEFLATED) as zf: | ||
| zf.writestr("course.json", course.model_dump_json(indent=2)) | ||
| if course.generation_info.image_bytes: | ||
| zf.writestr("cover.png", course.generation_info.image_bytes) | ||
| if course.generation_info.audio_bytes: | ||
| zf.writestr("audio.mp3", course.generation_info.audio_bytes) | ||
| buffer.seek(0) | ||
| return cls(zip_bytes=buffer.getvalue()) | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| from __future__ import annotations | ||
|
|
||
| """Prototype storage backends for holding generated course artifacts in memory.""" | ||
|
|
||
| from abc import ABC, abstractmethod | ||
| from pathlib import Path | ||
| from typing import Dict | ||
|
|
||
|
|
||
| class StorageBackend(ABC): | ||
| """Abstract interface for storing generated artifacts.""" | ||
|
|
||
| @abstractmethod | ||
| def save_bytes(self, path: Path, data: bytes) -> None: | ||
| pass | ||
|
|
||
| @abstractmethod | ||
| def load_bytes(self, path: Path) -> bytes | None: | ||
| pass | ||
|
|
||
|
|
||
| class FileSystemBackend(StorageBackend): | ||
| """Store artifacts on disk using the normal filesystem.""" | ||
|
|
||
| def save_bytes(self, path: Path, data: bytes) -> None: | ||
| path.parent.mkdir(parents=True, exist_ok=True) | ||
| path.write_bytes(data) | ||
|
|
||
| def load_bytes(self, path: Path) -> bytes | None: | ||
| if path.exists(): | ||
| return path.read_bytes() | ||
| return None | ||
|
|
||
|
|
||
| class InMemoryBackend(StorageBackend): | ||
| """Keep artifacts only in memory.""" | ||
|
|
||
| def __init__(self) -> None: | ||
| self._storage: Dict[Path, bytes] = {} | ||
|
|
||
| def save_bytes(self, path: Path, data: bytes) -> None: | ||
| self._storage[path] = data | ||
|
|
||
| def load_bytes(self, path: Path) -> bytes | None: | ||
| return self._storage.get(path) | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| from okcourse.models import CourseSettings, CourseGenerationInfo | ||
|
|
||
|
|
||
| def test_in_memory_settings_default(): | ||
| settings = CourseSettings() | ||
| assert settings.in_memory_output is False | ||
|
|
||
|
|
||
| def test_in_memory_settings_true(): | ||
| settings = CourseSettings(in_memory_output=True) | ||
| assert settings.in_memory_output is True | ||
|
|
||
|
|
||
| def test_generation_info_memory_fields(): | ||
| info = CourseGenerationInfo() | ||
| assert info.image_bytes is None | ||
| assert info.audio_bytes is None | ||
|
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.