Skip to content

fix(e2e): kind-chip locator for the card-list layout #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tjluyao merged 1 commit into from
May 25, 2026
Merged

fix(e2e): kind-chip locator for the card-list layout #6

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions tests/14-workflow-surface.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,12 +37,12 @@ test.describe("14 — workflow surface (W1)", () => {
// Lens tabs present.
await expect(page.getByRole("button", { name: "Live" })).toBeVisible();
await expect(page.getByRole("button", { name: "All" })).toBeVisible();
// At least one row.
const tableRows = page.locator("table tbody tr");
await expect.poll(async () => await tableRows.count(), { timeout: 10_000 }).toBeGreaterThan(0);
// Each row has a kind chip ("scheduled" or "visual").
const firstChip = tableRows.first().locator("text=/scheduled|visual/i");
await expect(firstChip).toBeVisible();
// At least one kind chip rendered (workflows list renders as a
// card-list, not a table — checking for the data-testid covers
// both pre- and post-W5 polish layouts and avoids matching the
// hidden filter <option> elements that also use these words).
const chip = page.locator('[data-testid^="kind-chip-"]').first();
await expect(chip).toBeVisible({ timeout: 10_000 });
});

test("workflow detail has Graph + Runs + Definition tabs", async ({ page }) => {
Expand Down
Loading