add shape parameter for PlotBMRSummary #1525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ja-thomas
reviewed
Mar 6, 2017
R/plotBMRSummary.R
Outdated
| @@ -53,8 +53,10 @@ plotBMRSummary = function(bmr, measure = NULL, trafo = "none", order.tsks = NULL | |||
| levels(df$learner.id) = getBMRLearnerShortNames(bmr) | |||
| } | |||
|
|
|||
| p = ggplot(df, aes_string(x = meas.name, y = "task.id", col = "learner.id")) | |||
| p = ggplot(df, aes_string(x = meas.name, y = "task.id", col = "learner.id", shape = "learner.id")) | |||
There was a problem hiding this comment.
We don't really want to hardcode this right?
R/plotBMRSummary.R
Outdated
| p = p + geom_point(size = pointsize, position = position_jitter(width = 0, height = jitter)) | ||
| # set shape to standard shape 19 | ||
| p = p + scale_shape_manual(values = rep(19, length(getBMRLearnerShortNames(bmr)))) |
There was a problem hiding this comment.
Have a look at #1523, this might be problematic for wrapped learners
|
what is the status here? work in progress? or ready for review? |
|
Work in progress, will have a look at it tomorrow |
jakob-r
approved these changes
Mar 8, 2017
larskotthoff
requested changes
Mar 9, 2017
|
What's the status here @QuayAu ? |
|
Looks good to me. We internally set the shape to the default (using |
|
@QuayAu can you add an example as requested by @larskotthoff ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR for #1470
This is still work in progress, as I need to add a unit test, that catches the problem that changing the shape parameter didn't have any effect.
Is there any simple way to test if generated ggplots are the same?