refactor: reduce run complexity and add Makefile#17
Merged
Conversation
## Summary - Extract initTailscale, handleShutdown, and drainActiveConnections from the run function - Reduce cyclomatic complexity of run function from 19 to 7 - Improve readability and maintainability of the main entry point
Unified local entry point for build, test, lint, security, shellcheck, cover and check (all-in-one). Aligns with CI pipeline targets.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
initTailscale(),handleShutdown(), anddrainActiveConnections()fromrun(), reducing cyclomatic complexity from 19 to 7 (threshold: 15)Makefilewith standard dev targets:build,test,lint,security,shellcheck,check,cover,cleanTest plan
make testpasses (all tests green with-race)make buildproduces binarymake shellcheckcleango vet ./...clean