chore(specs): archive SDD-001 + SDD-002 post-merge#52
Merged
Conversation
Per `pattern-spec-driven-development.md` archive policy ("On merge: mv
specs/<feature-id>/ specs/archive/<feature-id>/ + update status: archived
in proposal.md frontmatter"). Both SDD-001 (PR #49) and SDD-002 (PR #51)
shipped earlier this session; archiving was the housekeeping debt.
- git mv preserves history for both folders
- proposal.md frontmatter: status draft -> archived, archived date set, merged_pr field added
- No content changes -- pure housekeeping
This PR meets SDD skip criteria (documentation-only changes per pattern
line 80) so no nested vault entry + init-spec scaffold needed.
Vault updates separate (auto-synced):
- 10_projects/dotfiles/11-tasks.md: SDD-002 marked done with PR link
- 10_projects/dotfiles/90-lessons.md: 2 lessons promoted from SDD-001/002
verification.md flagged "YES for vault promotion"
mlorentedev
added a commit
that referenced
this pull request
May 22, 2026
…form) verify-setup.bats Section 9 grepped for the un-quoted scripts PATH line that ensure_line_in_file used to append. Now that the line is baked into the repo .bashrc/.zshrc with double quotes around $HOME (safer + matches the opencode PATH line's style), the old assertion no longer matched → integration CI fail (#50, #52). Updated: - Section header: "ensure_line_in_file side effects" → "rc file SSOT (lines baked into repo .bashrc/.zshrc — BUG-024)" since the mechanism is no longer setup-time mutation. - Test #50/#52 grep pattern now requires the double-quoted form that matches the repo source exactly (strict SSOT assertion, no looseness). - Test names: "X added to .Yshrc" → "X in .Yshrc" since nothing is being "added" at setup time anymore.
mlorentedev
added a commit
that referenced
this pull request
May 22, 2026
…nly writer of rc files (#93) * fix(BUG-024): bake PATH/alias lines into repo .bashrc/.zshrc to kill drift false-positive setup-linux.sh appended 3 lines (opencode PATH, project-init alias, dotfiles/scripts PATH) to ~/.bashrc and ~/.zshrc via ensure_line_in_file *after* symlinking them to the repo. Since the rc files are symlinks into the deploy-dir, the writes landed in the deploy-dir copies and made diff-check.sh (PR #10) report drift on every fresh setup. Root fix: repo source is now the only writer. The 3 lines are baked into .bashrc/.zshrc directly; the corresponding ensure_line_in_file blocks are removed from setup-linux.sh (L431-433, L903-905, L922-924). Both rc files also gained the trailing newline they were missing. Test: tests/opencode.bats #5 rewritten to assert the new invariant (repo-as-SSOT) and to forbid the old ensure_line_in_file pattern. * fix(BUG-024): update verify-setup.bats #50/#52 to match SSOT (quoted form) verify-setup.bats Section 9 grepped for the un-quoted scripts PATH line that ensure_line_in_file used to append. Now that the line is baked into the repo .bashrc/.zshrc with double quotes around $HOME (safer + matches the opencode PATH line's style), the old assertion no longer matched → integration CI fail (#50, #52). Updated: - Section header: "ensure_line_in_file side effects" → "rc file SSOT (lines baked into repo .bashrc/.zshrc — BUG-024)" since the mechanism is no longer setup-time mutation. - Test #50/#52 grep pattern now requires the double-quoted form that matches the repo source exactly (strict SSOT assertion, no looseness). - Test names: "X added to .Yshrc" → "X in .Yshrc" since nothing is being "added" at setup time anymore.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Housekeeping. Per
pattern-spec-driven-development.mdarchive policy:Both SDD-001 (#49) and SDD-002 (#51) shipped earlier this session; archiving was the pending housekeeping debt. This PR closes it.
Changes
git mv specs/SDD-001-discipline-gate specs/archive/SDD-001-discipline-gate(3 files)git mv specs/SDD-002-settings-portability specs/archive/SDD-002-settings-portability(3 files)proposal.mdfrontmatter in both:status: draft→archived+ addedarchived: 2026-05-18+merged_prfieldNo content changes beyond the frontmatter status. Pure housekeeping.
Why this PR doesn't need an SDD scaffold
Per the SDD Discipline Gate (added in PR #49 via AGENTS.md):
Documented in commit body.
Cross-references
00_meta/patterns/pattern-spec-driven-development.mdarchive policy section