refactor: extends the input type of zonesNormalize function

[jobo322]

there is a package that use zonesNormalize but those zones has the structure:

{ id: string } & FromTo

so should be nice to refactor this function to accept those kind of inputs and preserve in this particular case the id

[jobo322]

should we have zones if we pass only exclusion zones? and the input zones is empty?

[lpatiny]

@targos This is not a time critical code and I think it make sense to have this here.
WDYT ?

[targos]

What I care about is consistency. Please also do it in the other functions of the zones folder.

[targos]

Also, this seems to be a breaking change (see failing tests)

[jobo322]

Also, this seems to be a breaking change (see failing tests)

This method in particular can returns zones with an empty zones input. e.a

const result = zonesNormalize([], {
      from: 0,
      to: 10,
      exclusions: [{ from: 1, to: 2 }],
    });

this breaking change can be avoided by:

if (zones.length === 0) {
    zones.push({ from, to } as Zone);
  }

[lpatiny]

This is an issue because we will let think that it is a Zone but it does not have the expected properties. It could yields to bugs and this can not be accepted.

@targos I guess we could make function overload ? But I'm not sure this would really help

// Overload for when the array is empty
function test(array: []): FromTo;

// Overload for when the array is not empty
function test(array: number[]): Zone;

function test(array: number[]): FromTo | Zone {}

Otherwise we need to create a new method that just throws if the number of zones are empty

[targos]

Empty array does not exist in TypeScript

[lpatiny]

Zone is not used in this method and we don't return extended Zone (with points). Does not make sense to me.

[jobo322]

yes, better if we need to a similar method for and more general object better to implement a new one.