refactor: cleanup #20
Conversation
There was a problem hiding this comment.
Please restore the .docs/Readme.hbs
It is used as a template to generate the readme. It's a bit strange that it is in a hidden folder, you can change that.
Please check that the generation is still working (npm run docs) after re-installing the deps.
@targos do you know why the nodejs workflow isn't running in this PR?
No idea. I verified that actions are enabled for the repo. |
|
Btw I would be surprised if everything still works without changes given the huge amount of major dependency upgrades. |
Going to check what's the problem |
|
Yes I think the dependencies should not be bumped in this one. There is an ongoing branch which updates some of the deps, so there will be conflicts https://github.com/mljs/libsvm/tree/upgrade-deps I'm working on this on my free time but I think that branch can be merged once I find a few hours to finish it. |
|
Also the tests rely on code that is generated by emscripten, so no chance this will work without a build step first |
|
I think we should hold off on this PR. Finish your branch first, then work on this again (emscripten will have to be installed in the workflow somehow) |
No description provided.