Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Website 75 add links to respective floor plans to location aside #329

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

SalazarJosh
Copy link
Collaborator

@SalazarJosh SalazarJosh commented Jan 27, 2025

Overview

We've added a floor plan field to the location information view in Drupal. This field can have any number of floor plans assigned to it. This PR pulls that field to the Location/Building/Room content type GraphQL queries and outputs the link(s) and title(s) to each floor plan, if they're present.

This pull request resolves WEBSITE-75.

Anything else?

I also noticed that we were inconsistently using "floorplan" and "floor plan" throughout the site. This fix also makes them consistent by using the proper "floor plan".

Testing

This is a list of all the pages that currently include floor plans. It ensures that each content type is tested and represents a variety of floor plan quantities.

I also fixed the spelling for “floor plan” on these pages:

  • Book Arts Studio

  • Special Collections Reading Room

  • Event

  • Make sure the PR is consistent in these browsers:

    • Chrome
    • Firefox
    • Safari (the assignee was not able to test the pull request in this browser)
    • Edge
  • Run accessibility tests:

    • WAVE
    • ARC Toolkit
    • axe DevTools
    • NVDA screen reader

Looking up floorPlan all in the GraphQL query--no need to use useFloorPlan().
@SalazarJosh SalazarJosh marked this pull request as ready for review January 28, 2025 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant