Skip to content

v2.87.1

Compare
Choose a tag to compare
@conorom conorom released this 27 Jan 22:24

HELIO-4167
Initial PR, removing the timing-related JS for resizing audio embed iframe height.
This fix will pair with manual adjustment of the iframe height for the offending embeds.

This JS in theory made room for the transcript div in the embed, but it was always timing-dependent.
With the recent upgrade to Able Player 4.3, which lives in /public not the asset pipeline, the timing problem is very bad. Seemingly especially so for older-style books which have not been normalized for EmbedCodeService.

The ticket with require further PRs to alter EmbedCodeService to make these changes in future.