Skip to content

Support Windows OS #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
FlorentMeyer wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Support Windows OS #189

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1fa4d95
Fix url joining
Jul 8, 2024
3fd99b6
Fix missing file_handler directory
Jul 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions mlflow_export_import/client/http_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
from abc import abstractmethod, ABCMeta
import os
import json
import requests
from urllib.parse import urljoin
import click
from mlflow_export_import.common import MlflowExportImportException
from . import USER_AGENT
Expand Down Expand Up @@ -94,7 +94,7 @@ def __init__(self, api_name, host=None, token=None):
http_status_code=401
)
self.host = host
self.api_uri = os.path.join(host, api_name)
self.api_uri = urljoin(host, api_name)
self.token = token


Expand Down
2 changes: 2 additions & 0 deletions mlflow_export_import/common/logging_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,4 +55,6 @@ def _create_default_log_config(output_path=None, log_format=None):
handlers = cfg["root"]["handlers"]
handlers.remove("file")

os.makedirs(os.path.dirname(cfg["handlers"]["file"]["filename"]), exist_ok=True)

return cfg