Skip to content

Improve sqlite support #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
FlorentMeyer wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Improve sqlite support #188

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion mlflow_export_import/experiment/export_experiment.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,6 @@ def export_experiment(
"""

mlflow_client = mlflow_client or create_mlflow_client()
dbx_client = create_dbx_client(mlflow_client)

run_start_time_str = run_start_time
if run_start_time:
Expand Down Expand Up @@ -91,6 +90,7 @@ def export_experiment(

mlflow_attr = { "experiment": exp_dct , "runs": ok_run_ids }
if export_permissions:
dbx_client = create_dbx_client(mlflow_client)
mlflow_attr["permissions"] = ws_permissions_utils.get_experiment_permissions(dbx_client, exp.experiment_id)
io_utils.write_export_file(output_dir, "experiment.json", __file__, mlflow_attr, info_attr)

Expand Down
2 changes: 1 addition & 1 deletion mlflow_export_import/run/export_run.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,6 @@ def export_run(
"""

mlflow_client = mlflow_client or create_mlflow_client()
dbx_client = create_dbx_client(mlflow_client)

if notebook_formats is None:
notebook_formats = []
Expand Down Expand Up @@ -96,6 +95,7 @@ def export_run(
# export notebook as artifact
if notebook is not None:
if len(notebook_formats) > 0:
dbx_client = create_dbx_client(mlflow_client)
_export_notebook(dbx_client, output_dir, notebook, notebook_formats, run, fs)
elif len(notebook_formats) > 0:
_logger.warning(f"No notebooks to export for run '{run_id}' since tag '{MLFLOW_DATABRICKS_NOTEBOOK_PATH}' is not set.")
Expand Down