Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions .env
Original file line number Diff line number Diff line change
@@ -1,7 +1,3 @@
# if you want to use modelbench from modelbench-private, uncomment below line
# NOTE: this will not work if you do not have access to that repo
# USE_PRIVATE_MODELBENCH=true

# postgres env for local mlflow tracking server
# you don't need to set these if mlflow is already running somewhere else
# (in that case, you don't need postgres at all)
Expand Down
4 changes: 0 additions & 4 deletions .env.jupyteronly
Original file line number Diff line number Diff line change
@@ -1,7 +1,3 @@
# if you want to use modelbench from modelbench-private, uncomment below line
# NOTE: this will not work if you do not have access to that repo
USE_PRIVATE_MODELBENCH=true

# THIS MUST BE SET
MLFLOW_TRACKING_URI=https://modelplane.mlflow.dev.modelmodel.org

Expand Down
4 changes: 0 additions & 4 deletions .env.nojupyter
Original file line number Diff line number Diff line change
@@ -1,7 +1,3 @@
# if you want to use modelbench from modelbench-private, uncomment below line
# NOTE: this will not work if you do not have access to that repo
# USE_PRIVATE_MODELBENCH=true

# postgres env for local mlflow tracking server
# you don't need to set these if mlflow is already running somewhere else
# (in that case, you don't need postgres at all)
Expand Down
10 changes: 1 addition & 9 deletions Dockerfile.jupyter
Original file line number Diff line number Diff line change
@@ -1,9 +1,6 @@
FROM python:3.12-slim

ARG USE_PRIVATE_MODELBENCH

ENV PATH="/root/.local/bin:$PATH"
ENV USE_PRIVATE_MODELBENCH=${USE_PRIVATE_MODELBENCH}
# Used for the notebook server
WORKDIR /app

Expand All @@ -18,12 +15,7 @@ RUN mkdir -p /root/.ssh && chmod 700 /root/.ssh
RUN git config --global core.sshCommand "ssh -o UserKnownHostsFile=/root/.ssh/known_hosts -o ForwardAgent=yes"
RUN ssh-keyscan github.com > /root/.ssh/known_hosts

# conditionally forward ssh key to install private dependencies
RUN --mount=type=ssh if [ "$USE_PRIVATE_MODELBENCH" = "true" ]; then \
poetry install --no-interaction --no-ansi --no-root --extras modelbench-private; \
else \
poetry install --no-interaction --no-ansi --no-root; \
fi
RUN poetry install --no-interaction --no-ansi --no-root

COPY src/ ./src/
RUN echo $(poetry env info --path)
Expand Down
3 changes: 0 additions & 3 deletions docker-compose.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -60,13 +60,10 @@ services:
build:
context: .
dockerfile: Dockerfile.jupyter
args:
USE_PRIVATE_MODELBENCH: ${USE_PRIVATE_MODELBENCH}
environment:
MLFLOW_TRACKING_URI: ${MLFLOW_TRACKING_URI}
MLFLOW_TRACKING_USERNAME: ${MLFLOW_TRACKING_USERNAME}
MLFLOW_TRACKING_PASSWORD: ${MLFLOW_TRACKING_PASSWORD}
USE_PRIVATE_MODELBENCH: ${USE_PRIVATE_MODELBENCH}
JUPYTER_TOKEN: ${JUPYTER_TOKEN}
GIT_PYTHON_REFRESH: ${GIT_PYTHON_REFRESH}
VLLM_API_KEY: ${VLLM_API_KEY}
Expand Down