Pipeline retries #908
Merged
Pipeline retries #908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkorycki
had a problem deploying
to
Scheduled Testing
GitHub Actions
Error
bkorycki
had a problem deploying
to
Scheduled Testing
GitHub Actions
Error
bkorycki
had a problem deploying
to
Scheduled Testing
GitHub Actions
Error
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
rogthefrog
reviewed
Mar 21, 2025
| response = annotator.annotate(request) | ||
| break | ||
| except Exception as e: | ||
| logger.warning( |
There was a problem hiding this comment.
Should there be a pause before the retry?
| response = sut.evaluate(request) | ||
| break | ||
| except Exception as e: | ||
| logger.warning(f"Exception calling SUT {sut.uid} on attempt {tries}: {e}\nRetrying.....", exc_info=True) |
There was a problem hiding this comment.
Is 10 seconds enough you think?
| @@ -239,6 +242,22 @@ def test_annotator_worker_cache_different_annotators(annotators, tmp_path): | |||
| assert annotators["annotator_dict"].annotate_calls == 1 | |||
|
|
|||
|
|
|||
| def test_annotator_worker_retries_until_success(): | |||
bkorycki
temporarily deployed
to
Scheduled Testing
GitHub Actions
Inactive
bkorycki
temporarily deployed
to
Scheduled Testing
GitHub Actions
Inactive
bkorycki
temporarily deployed
to
Scheduled Testing
GitHub Actions
Inactive
bkorycki
temporarily deployed
to
Scheduled Testing
GitHub Actions
Inactive
bkorycki
temporarily deployed
to
Scheduled Testing
GitHub Actions
Inactive
bkorycki
temporarily deployed
to
Scheduled Testing
GitHub Actions
Inactive
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pipeline runner (which used by
run-jobandrun-csv-items) now will keep retrying calls to SUTs and annotators until it gets a successful response. It logs exceptions and retry counts so that a user can manually stop the command if they see that it is retrying an impossible exception a million times.